*IVOA DAL WG Running Meeting #15

*Friday 10 March 2023 - 06:00 UTC - vconf


Participants: (6) François Bonnarel (FB), Markus Demleitner (MD), James Dempsey (JD), Grégory Mantelet (GM), Marco Molinaro (MM), Mark Taylor (MT)


*Agenda

	1. ADQL-2.1 Document
	2. ADQL-2.1 Validation
	3. Status of ADQL-2.1 implementations
	4. Ready for RFC?
	5. Other business (SODA, Datalink, DAP)


*1. ADQL-2.1 Document

	* Remaining issues for ADQL-2.1: https://github.com/ivoa-std/ADQL/milestone/1
	* [GM] Will merge the two open PRs today (Fri. 10 March 2023)
	* [GM] Will do a final read before RFC next week


*2. ADQL-2.1 Validation

(see also  https://wiki.ivoa.net/internal/IVOA/IvoaDAL_RunningMeetings/2023_ADQL_Validator.pdf for validator notes, status and sum up)

	* Generic off-line validator proposed in the Lyonetia GitHub repository (https://github.com/ivoa/lyonetia).
		* Based on VOLTT/ADQL-Lib
	* There's a second implementation against DaCHS in adql/gavo/testdachs.py (https://github.com/ivoa/lyonetia/blob/master/src/adql/gavo/testdachs.py)
	* 1 Pull-Request left with some points to discuss: #16 - https://github.com/ivoa/lyonetia/pull/16
	* Tests to be discussed
		* leading underscore in names
			* cf ivoa/1_select.xml#fe956f66-3c3e-410d-baa4-59305da8ddfc
			* DaCHS allows this so will filter this specific failure out
			* General question - should the validator test for things not allowed in spec as implementors may be more lenient
			* Action: Leave in and MD will ignore for DaCHS
		* column name in select starting as digit, which is not allowed by BNF
			* cf ivoa/1_select.xml#85e497ac-4403-4f84-8aa0-a3ee3da514cc
			* tokenisation rules (from SQL92) mean this is interpreted as 2 different tokens with an optional AS between
			* Action: Will remove test and not make a statement about this- can be revisited and potentially disallow in PEG grammar by specifying tokenisation
		* missing whitespace for 2desc in order by clause
			* cf ivoa/0_whitespace#a66c56e6-f18d-11e8-96df-28d244962af0
			* Again, tokenisation rules from SQL92
			* Should be accepted by validator but currently fails
			* Action: Remove test and address in PEG grammar
		* NATURAL implied but not supplied in join
			* cf ivoa/0_whitespace.xml#d4c3a72c-4458-11e6-96e2-28b2bdcff70b, #dbef92f4-4458-11e6-96e2-28b2bdcff70b, #1f5d27dc-450c-11e6-8564-332de33a5c03
			* Action: Update test to either prodice NATURAL or a USING clause
		* Complex STC-s involving union and intersection
			* cf ivoa/O1_geometrical_functions#1655f288-4d02-11e6-8c9d-819288b39233
			* Failing as VOLTT does not suport therse complex expressions
			* Action: GM to update VOLTT
		* Declaring UDFs for tests
			* cf ivoa/O1_geometrical_functions
			* VOLTT requires a full definition
			* DaCHS requires a name prefix but doesn't support declaration of function in the parser
			* MD: Would like functions to be specific to each test, not global to the file
			* Action: GM to move function defs to each test rather than global



*3. Status of ADQL-2.1 implementations

	* DACHS: OK
	* CADC: ?
	* VOLLT: OK


*4. Ready for RFC?

	* Yes once PRs and validator issues resolved


*5. Other business (SODA, Datalink, DAP)

	* [FB] Datalink ready for RFC - need confirmation from Pat Dowler [JD to email]
	* [FB] SIA1 should be ready for WD by interop - still some issues being discussed in PRs
	* [FB] SODA new PRs needed before interop
	* See slides for details : https://wiki.ivoa.net/internal/IVOA/IvoaDAL_RunningMeetings/DalRunning10-DL-DAP-SODA.pdf